Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(gateway,http,lavalink): Update to rustls 0.23 #2367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gelbpunkt
Copy link
Member

@Gelbpunkt Gelbpunkt commented Aug 28, 2024

This also adds support for rustls-platform-verifier and makes it the default. Further, support for aws-lc-rs is added, but not enabled by default.

Users disabling default features will have to manually enable a crypto backend for rustls now or install a global default using the rustls' CrytoProvider::install_default method 1.

@Gelbpunkt Gelbpunkt added c-http Affects the http crate c-gateway Affects the gateway crate c-lavalink Affects the lavalink crate t-build Changes that affect the build system or external dependencies labels Aug 28, 2024
@github-actions github-actions bot added the c-all Affects all crates or the project as a whole label Aug 28, 2024
@Gelbpunkt Gelbpunkt force-pushed the rustls-0.23 branch 9 times, most recently from 8f5b835 to cb09f58 Compare September 4, 2024 09:18
@Gelbpunkt Gelbpunkt marked this pull request as ready for review September 4, 2024 09:19
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document that you can install your own provider? Other than that it looks good.

@Gelbpunkt
Copy link
Member Author

Should we document that you can install your own provider? Other than that it looks good.

Oh, good catch. I completely forgot to document the crypto provider features. Will add a followup for that soon.

This also adds support for rustls-platform-verifier and makes it the
default. Further, support for aws-lc-rs is added, but not enabled by
default.

Users disabling default features will have to manually enable a crypto
backend for rustls now or install a global default using the rustls'
CrytoProvider::install_default method [1].

[1]: https://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html#method.install_default

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt
Copy link
Member Author

Added some crypto provider feature flag documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-all Affects all crates or the project as a whole c-gateway Affects the gateway crate c-http Affects the http crate c-lavalink Affects the lavalink crate t-build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants