Adds business services, services dependencies, custom fields and service id filters #50
Conversation
|
Thank you for the contribution @sam-io and welcome to Steampipe 👍 !! Could you please take a look at the lint failure: Additionally, since we have an SDK update, I believe it is worth checking for breaking changes that might affect the plugin's original functionality. I would recommend verifying that the old tables work consistently with the new SDK without altering the results 👍. |
|
Thank you @misraved I have fixed the lint issues and checked for possible breaking changes by looking through the change log and comparing the output of the old and new version of the plugin. I did not find any changes that could cause compatibility issues. |
There was a problem hiding this comment.
Hello @sam-io,
The changes look good to me overall. However, could you please address the following points?
- Could you update the hydrate function names to use the prefixes
getorlistinstead ofhydrateto maintain consistency? - Could you replace our custom function:
GetServiceDependencieswith the built-in SDK function ListTechnicalServiceDependencies?GetBusinessServiceDependencieswith ListBusinessServiceDependenciesWithContext
- Could you structure the API response based on the data returned by the API?
- Currently, all custom API calls return a structure
map[string]interface{}. - Can we tie up the custom API calls with a Go structure to visualize the API response better?
- This way, if the response changes from the API end in the future, we can clearly identify the missing fields.
- Currently, all custom API calls return a structure
Thank you!
| @@ -175,6 +180,26 @@ func tablePagerDutyIncident(_ context.Context) *plugin.Table { | |||
| Description: "The teams involved in the incident's lifecycle.", | |||
| Type: proto.ColumnType_JSON, | |||
| }, | |||
| { | |||
| Name: "service_id", | |||
There was a problem hiding this comment.
Could you please arrange the columns by column type, moving the JSON columns towards the bottom and placing the other columns towards the top?
Overview
Tables and columns
This PR introduces the following changes:
pagerduty_business_servicethat returns data from the pagerduty business services api.dependencieson thepagerduty_servicetable that contains service dependencies of a service.service_idon the 'pagerduty_incident' table that maps to theservice_ids[]query parameter in the list incidents API.custom_fieldson the 'pagerduty_incident' table that contains custom field values for an incident.impacted_business_serviceson the 'pagerduty_incident' table that contains business services that are impacted by an incident.Additional Changes
In addition to these changes the pagerduty api client is updated to the latest version.
Notes
There are some APIs that are supported by pagerduty but are not implemented by the pagerduty API client. These include:
Support for these has been included by introducing an
ExtendedPagerDutyClienttype that implements functions to call these APIs and return the results as a basicmap[string]interface{}that is sufficient for mapping to a table.Example query results
pagerduty_business_service
Listing all business services
Results
pagerduty_service
Getting technical services along with their immediate dependencies
Results
pagerduty_incident
Listing incidents including custom field values and business services impacted by the incident
Results
Results