Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare uuid dependency and v5 feature #842

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Sep 23, 2024

In Rust, features are additive. So when compiling the whole workspace, v5 gets enabled.

However, when just compiling migration, then the uuid crate will use used without any v* features, as declared by the seaorm cargo file.

Closes #839

In Rust, features are additive. So when compiling the whole workspace,
v5 gets enabled.

However, when just compiling `migration`, then the `uuid` crate will
use used without any `v*` features, as declared by the seaorm
cargo file.

Closes trustification#839
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah simple I see, thx! LGTM

@ctron ctron added this pull request to the merge queue Sep 23, 2024
Merged via the queue into trustification:main with commit 7dc1889 Sep 23, 2024
3 checks passed
@ctron ctron deleted the feature/fix_migration_1 branch September 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling back last migration throws error from previous migration
2 participants