Add tests to see if maven/semver version_matches is right or not. #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrossley3
reviewed
Sep 17, 2024
Signed-off-by: Jim Crossley <jim@crossleys.org>
Seems to be right.
jcrossley3
force-pushed
the
version-cmp-test
branch
from
5bc6f13
to
a3e4687
Compare
with wackadoodle CVEs claiming Maven is semver, along with our wackadoodle elision of actually checking version ranges. And fix all of the above.
jcrossley3
reviewed
Sep 17, 2024
| @@ -0,0 +1,110 @@ | |||
|
|
|||
| create or replace function mavenver_cmp(left_p text, right_p text) | |||
There was a problem hiding this comment.
I guess we have to do this logic in the db? Too much potentially returned to post-process? All the SQL makes my eyes bleed on to the vomit I just threw up. 👀 🍴 🤮
There was a problem hiding this comment.
Yep, we want to do it in the DB, so that we can also support suitable pagination.
Else, we have to bring them all back, and scrobble around on the rust side winnowing things out of the version ranges.
There was a problem hiding this comment.
Add just a touch of Sriracha, and the bloodvomit will be lovely.
There was a problem hiding this comment.
I was once in a band named "bloodvomit"
jcrossley3
approved these changes
Sep 17, 2024
Comment on lines
+318
to
+321
| /* | ||
| TODO: Gilles! | ||
| These statuses are *not* reflected in the CSAF regarding the quarkus 3.2.11 SBOM, which is the `sbom_id` from results[1] above. | ||
|
|
There was a problem hiding this comment.
Create an issue for this?
|
Thanks for merging! Your report, your privilege. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be right.