feat: add progress support, backed by the database #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
force-pushed
the
feature/progress_2
branch
from
cb665a9
to
a5da2a3
Compare
ctron
force-pushed
the
feature/progress_2
branch
from
a5da2a3
to
c6ad385
Compare
|
Looks good, just one question: If it persists in the DB, and the system shuts down mid-ingestoring, and then restarts, do the tables in the DB represent stale data? Or will it reset when the ingestor starts again? I understand the DB is nice especially if we distribute importers to different processes than the API servers (or have multiple API servers in rotation). |
bobmcwhirter
approved these changes
Aug 27, 2024
That's already happening. Clearing the progress data with it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the progress support to CSAF and SBOMs. It also persists the progress state in the database, and makes it available on the API.