-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo xtask precommit
rename validate-openapi
to openapi
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `cargo xtask precommit` does: generates the schema, generates openapi, validates openapi, cargo fmt, cargo clip, and cargo check. * the `cargo xtask openapi` command now generates and validates (it has flags to skip either). * the `cargo xtask gnerate-schemas` now only generates the schemas.
still working on fedora 👍 Compiling xtask v0.1.0-alpha.13 (/home/heliofrota/Desktop/tc/trustify/xtask)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 02s
Running `target/debug/xtask openapi`
Writing openapi to "openapi.yaml"
Validating openapi at "openapi.yaml"
Validating spec (/src/openapi.yaml)
Warnings:
- Unused model: AdvisoryVulnerabilityAssertions
- Unused model: Assertion
- Unused model: Uuid
[info] Spec has 3 recommendation(s).
➜ trustify git:(xtask) cargo xtask openapi |
helio-frota
approved these changes
Aug 15, 2024
trying on OSX, will report back. |
Okay, it's the relative path that's problematic. If I specify
Whereas the xtask is just using
|
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
bobmcwhirter
approved these changes
Aug 15, 2024
Works on OSX now
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should streamline the xtask commands a bit.
cargo xtask precommit
does: generates the schema, generates openapi, validates openapi, cargo fmt, cargo clip, and cargo check.the
cargo xtask openapi
command now generates and validates (it has flags to skip either).the
cargo xtask gnerate-schemas
now only generates the schemas.