Light up migrations and entities for: #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bobmcwhirter
commented
Aug 13, 2024
bobmcwhirter
commented
- licenses, in general.
- sbom-centric license assertions
- add license info into purl DTOs.
dejanb
reviewed
Aug 14, 2024
| #[derive(Copy, Clone, Debug, EnumIter, DeriveRelation)] | ||
| pub enum Relation {} | ||
|
|
||
| impl ActiveModelBehavior for ActiveModel {} |
There was a problem hiding this comment.
Looks good on first look. The only thing I noticed that relations for cpe assertion are missing. But that might be coming later
There was a problem hiding this comment.
Yah, currently I haven't tried any fetching for CPEs, which is where Relations come into play.
Do we have endpoints for CPEs currently? Directly or via Products?
There was a problem hiding this comment.
Not that I'm aware of. I hope to have something via products soon
* licenses, in general. * sbom-centric license assertions to purls and CPEs. * add license info into purl DTOs. Fix cascading deletes. Ensure each SPDX license is also a root/regular license. Connect endpoints. Allow querying (paginatedly) for pURLs under a given license. Update the openapi YAML.
dejanb
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.