Fix error that occured when updating the home page by admin #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an error when we try to update the home page through admin panel: ``` Oops, you've missed a required field. Please complete before saving. ``` I happens, because the `posthogLabel` field was required for Liquidity Provider Role section and it is not set by default in `stc/content/pages/index.md` file. The posthog label for this button is not needed anyway so it was probably added there by mistake.
|
Preview uploaded to https://preview.threshold.network/fix-posthog-label-issue-in-admin-page/index.html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error when we try to update the home page through admin panel:
Screenshot
It happens, because the
posthogLabelfield was required for Liquidity Provider Role section and it is not set by default instc/content/pages/index.mdfile. The posthog label for this button is not needed anyway so it was probably added there by mistake in #70.This PR removes that unnecessary field from the Liquidity Provider Roles buttons.