AwS setup #14
Open
AwS setup #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes some minor memory leaks related to mpp_domains. The following fields have been added to `mpp_deallocate_domain`: * domain%tileList * domain%tile_id_all * domain%check_[CEN] * domain%bound_[CEN] * domain%update_[CEN] as well as the `overlap_type` field * overlap%index I was unsure if `tileList` and `tile_id_all` were always or conditionally allocated, so they are wrapped in `associated()` checks. But this may be redundant.
…ags are pushed. Build is done with intel18 on parallel works azure cloud cluster
Domain mem leaks
Updates time manager testing scripts for testing old and new set/get_date_gregorian routines
Sets explicit array length to avoid PGI issues with select case
Adds an action to run `make check` through parallel works on main branch for testing tags
* Replace time_interp_external with time_interp_external2 in tests and gets the test to run * forgot to completely remove the input_base_nml * replace mosaic with mosaic2 in tests * correctly writes str array for gnu * Clean up the directory after tests * replaces axis_utils_mod with axis_utils2 and gets unskips the test * Removes the if def internal_file_nml and any other use fms_io_mod * Adds a unit test for axis_edges * more mpp_io/fms_io removal Co-authored-by: Ryan Mulhall <35538242+rem1776@users.noreply.github.com>
* removes unused include file * Removes the netcdf_version_skip flag, modifies test_global_att.F90 to test the different netcdf types, removes the get_global_attributes calls from the other tests * Adds a more implicit(?) error message * improve error message in get/register_global_attribute * Fixes some error messages in fms2_io * Improves errors messages in fms2io * reverts a wrong change * Clean up more error messages * updates all of the error messages in fms_io_utils.F90 * updates more error messages * completely removes the SKIP_FMS2_IO_TESTS flag in configure * Corrects minor typos in test_fms/fms2_io/test_global_att.F90 to make comments consistent * Partially reverts previous commit Co-authored-by: Ryan Mulhall <35538242+rem1776@users.noreply.github.com>
…OAA-GFDL#780) * Adjusting num_lines in mpp_util.inc * Adjusting num_lines in mpp_util.inc, as well as an option to output the lines_and_length parameter in ascii_read. * Using Rustys version * Added appropriate documentation and deallocation of ascii_var if allocated within ascii_read * Split the output in the optional arguments of ascii_read in fms2_io * Fixed arguments to ascii_read
fix filenames in cmakelists.txt
Small test fixes for fms2_io and time_interp
* Added option to specify an alt_input_nml_path to fms_init, and therefore mpp_init * Edit read_input_nml call to properly use optional arguments * Eliminating use of hardcoded input.nml * Removed INPUT_STR_LENGTH references from test harness and mpp
Removed use_mpp_io from diag_manager and drops a fatal if it's set to true
* added an option to run a regional domain as the top-level for the nesting and fixed code so mpp_exit works as expected * reformulated the nest overlap logic to handle non-standard cases properly * added an if-test to determine whether to use MPP_DEBUG within mpp_domains_init call
…grid Removed use_mpp_io from xgrid and drops a fatal if it's set to true
* Added grid_spec_exists tests to functions and subroutines that use gridfileobj within grid2.F90
* Add missing library files (sat_vapor_pres, diag_integral, global FMS module) to libFMS.la * Fix a typo for checking if on cray systems in configure.ac
Updates version number in configure.ac to 2021.04.0-dev
Cleans up unnecessary writes/buffers in diag_manager and diag_output when writing fields and fixes dimension argument ordering issues with diurnal output. Adds a unit test for diurnal output functionality.
Adds Github actions for intel builds on pull request, and tests for FMS and AM4 on alpha or beta tags
…-GFDL#811) Fixes load_record read_data call for 3d variables with fms2_io. Eliminates redundant data loading and validity checking for on-grid interpolations.
Update compiler version check in configure script to only error on 11.1.0, not any subsequent versions
Newer Intel compilers use the -real-size option to change the default Fortran real kind when building. This updates m4/gx_fortran_options.m4 to include the new flag in the build system in order to avoid compiler warnings.
This patch fixes some memory issues and errors in the `mpp_type_free` function in `mpp_comm_mpi.inc`, mostly related to the handling of the default `mpp_byte` type.
Changes for the JCSDA to enable data assimilation applications Mainly allows for custom path names for files in `get_mosaic_tile_grid` from `fms_io.F90`
Adds environment variable to CI yaml file needed to pass configure flags to `make distcheck`. Fixes compilation issue with mixed mode in mpp_io unit test.
Removal of hardcoded etc_unit of 9, and replacement with newunit calls in open statements. Adds deprecation warning to get_unit.
Adds routine to flush_nc_files via fms2_io if the namelist variable in diag_data.F90 is set.
Fixes for the parallelworks CI in it's workflow yaml file
…GFDL#834) Removes deprecated Gregorian calendar code and it's test from time_manager.F90
Adds a routine to fms_mod to convert c string pointers to fortran strings, and adds a unit test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up a GitHub runner to be used with Amazon EC2 to run automatically on pull requests.
How Has This Been Tested?
Testing with this PR
Checklist:
make distcheckpasses