Use branching date as target_date in branching procedures #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All procedures currently accept a single target_date. For branching procedures in particular, if the branching date is used as the target_date, this generates correct dates in the section headings but an incorrect date in the command invocation to generate the release procedure. This commit fixes the inconsistency by assuming the branch date is the target_date in branching, and adding four weeks to that date to get the date for GA.
ekohl
requested changes
Jan 29, 2024
|
@ekohl so, using the current cycle as an example, the target_date used to generate the release procedure should be February 20th, even though GA is planned for March 19th, because the target_date is referring to RC1 and not to GA? Is the RC1 release procedure the only one that is generated in this way? |
|
That is exactly what is happening, so it's all working as intended. Targeted branching date is equal to targeted RC1 date. |
|
Cool, thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All procedures currently accept a single target_date. For branching procedures in particular, if the branching date is used as the target_date, this generates correct dates in the section headings but an incorrect date in the command invocation to generate the release procedure. This commit fixes the inconsistency by assuming the branch date is the target_date in branching, and adding four weeks to that date to get the date for GA.