Reduce settings needed for every release #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly requires it to be set when needed. This allows some things to be simplified.
Client always matches Foreman's version.
|
Untested for now, so a draft. @ehelms is |
Let's assume dropable for now. |
|
@ekohl I'd love for you to revisit this so I can finish off the Copr work and align our use of scripts in CI and locally. |
|
@evgeni mind giving this a sanity check? |
evgeni
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly requires FULLVERSION to be set when needed. This allows them to be dropped from client and pulpcore settings.
It also automatically sets it for
FOREMAN_VERSION, not in every single settings file.