Unbreak Pulp Nightly pipelines #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Dec 14, 2023
| @@ -59,7 +59,7 @@ def comps(collection, version, dist, foreman_version): | |||
| repo = 'candlepin-packaging' | |||
| elif collection == 'pulpcore': | |||
| repo = 'pulpcore-packaging' | |||
| branch = version | |||
| branch = 'develop' if version == 'nightly' else version | |||
There was a problem hiding this comment.
wouldn't branch = 'develop' if foreman_version == 'nightly' else foreman_version from above do the same already, and we woulnd't have to set branch here at all?
There was a problem hiding this comment.
Pulpcore was not getting the right version, it was using the foreman_version, after adding
branch = version it started to try to fetch the comps in the brach nightly that does not exist
There was a problem hiding this comment.
ad4f67c fixed pipelines that are not on develp/nightly
evgeni
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.