Drop Ruby 2.5 support

[archanaserver]

For refernce: #122 (comment)

[ehelms]

@archanaserver Can you rebase this?

[ehelms]

I am proposing we drop the smart_proxy_dynflow Jenkins tests -- theforeman/jenkins-jobs#346

[archanaserver]

I am proposing we drop the smart_proxy_dynflow Jenkins tests -- theforeman/jenkins-jobs#346

In a favour of this one, I have raised a new PR to drop the Jenkins changes #124.

[ehelms]

Interesting, something triggered an update to a version of minitest where all the MiniTest should now be Minitest -- could you look at doing that in a separate PR? I don't think it has to do with this change in particular.

[archanaserver]

Interesting, something triggered an update to a version of minitest where all the MiniTest should now be Minitest -- could you look at doing that in a separate PR? I don't think it has to do with this change in particular.

Raised the changes here #125

[ehelms]

@archanaserver This can be rebased now

[ekohl]

@adamruzicka can you help understand why this one test fails?

[adamruzicka]

Maybe if this was reproducible. Last three runs in #126 with the same changes as here were successful and I haven't succeeded in reproducing it locally. When I rerun the tests here it passed.

[ekohl]

IIRC minitest also has test order randomization, but perhaps I'm confusing it with rspec. Have you tried rerunning with the same seed to get the same order?

[adamruzicka]

It didn't seem to make any difference

[ehelms]

I also could never reproduce it and I only ever saw it fail on Jenkins (which is no longer an issue?).

[ekohl]

This failure was in GitHub Actions.

[ekohl]

@adamruzicka shall we merge this?

[adamruzicka]

Thank you everyone!