Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync to project directory #1870

Merged
merged 1 commit into from
Aug 28, 2023
Merged

rsync to project directory #1870

merged 1 commit into from
Aug 28, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 27, 2023

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Aug 28, 2023

@ekohl mind taking a look at this one? I need it to properly rsync over with the right structure and I figured we should reduce storage usage.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The idea behind keeping a cache is that you speed up future executions. Perhaps you need the --delete option to remove deleted files?

@ehelms
Copy link
Member Author

ehelms commented Aug 28, 2023

Why? The idea behind keeping a cache is that you speed up future executions. Perhaps you need the --delete option to remove deleted files?

I also noticed that we do a clean up in freight? Is that for a different reason?

https://github.com/theforeman/foreman-infra/blob/master/puppet/modules/freight/templates/rsync.erb#L13-L14

I assume you are saying the a delete would need to be added here? https://github.com/theforeman/jenkins-jobs/pull/349/files#diff-c12500cef361f017ede0862bcabf9b799c8e4b9287be181a1d74203617208968R482

@ehelms
Copy link
Member Author

ehelms commented Aug 28, 2023

For now I have isolated this just to the rsync location update to allow me to continue testing and will leave the conversation around cleanup to be separate on whether we do that or not.

@ehelms ehelms changed the title rsync to project directory and cleanup cache after rsync to project directory Aug 28, 2023
@ehelms ehelms merged commit 852eb5f into theforeman:master Aug 28, 2023
2 checks passed
@ekohl
Copy link
Member

ekohl commented Aug 28, 2023

Good question. Perhaps that's more a case of "it was always that way"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants