Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #95

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Add GitHub Actions #95

merged 1 commit into from
Aug 5, 2023

Conversation

tfoxy
Copy link
Owner

@tfoxy tfoxy commented Aug 5, 2023

Based on the workflows in graphql-python/graphene-django/.github/workflows, but adapted to use the same versions and tools that we were already using in Travis CI so that we can make sure everything works as before. Removed Python 3.6 as it's not supported in the latest version of Ubuntu in GHA.

@tfoxy tfoxy self-assigned this Aug 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (474bc68) 93.63% compared to head (1677204) 93.71%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   93.63%   93.71%   +0.07%     
==========================================
  Files           7        7              
  Lines         330      334       +4     
==========================================
+ Hits          309      313       +4     
  Misses         21       21              
Files Changed Coverage Δ
graphene_django_optimizer/query.py 92.10% <100.00%> (-0.03%) ⬇️
graphene_django_optimizer/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfoxy tfoxy merged commit ebd8402 into master Aug 5, 2023
12 checks passed
@tfoxy tfoxy deleted the github-actions branch August 5, 2023 18:56
@tfoxy
Copy link
Owner Author

tfoxy commented Aug 5, 2023

@sjdemartini we now have CI working correctly. Didn't check if publishing works. It's almost the same config as graphene-django and I added the secret, so hopefully it works.

I used the same versions and tools of the Travis config to break things as little as possible and to have it working ASAP. But feel free to change anything in the future if it makes things easier/better.

@sjdemartini
Copy link
Collaborator

Amazing, thank you @tfoxy! Really appreciate you getting this in place and for releasing the version update. I'll test it out in my project next week 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants