Skip to content

Commit

Permalink
Dynamic vs. static: making FoundationExtensions the static default (#36)
Browse files Browse the repository at this point in the history
Renamed startic / dynamic, make sure that packages without any suffix are static. This unifies
a inconsistency in a lot of framworks used in our products. Also, static linking is is an attempt to
fix this issue while deploying to TestFlight / AppStore:

ITMS-90334: Invalid Code Signature Identifier. The identifier "FoundationExtensions-5555494443d5626ab868338a93cce6b274e34595"
in your code signature for "FoundationExtensions" must match its Bundle Identifier "FoundationExtensions"

FoundationExtensions is the default now, the dynamic product is FoundationExtensionsDynamic.
  • Loading branch information
melle committed Sep 6, 2022
1 parent 503d411 commit 79ebeb6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ let package = Package(
name: "FoundationExtensions",
platforms: [.iOS(.v12), .macOS(.v10_15), .tvOS(.v13), .watchOS(.v6)],
products: [
.library(name: "FoundationExtensions", type: .dynamic, targets: ["FoundationExtensions"]),
.library(name: "FoundationExtensionsStatic", targets: ["FoundationExtensions"])
.library(name: "FoundationExtensions", targets: ["FoundationExtensions"]),
.library(name: "FoundationExtensionsDynamic", type: .dynamic, targets: ["FoundationExtensions"])
],
dependencies: [],
targets: [
.target(name: "FoundationExtensions", dependencies: []),
.target(name: "FoundationExtensionsDynamic", dependencies: []),
.testTarget(name: "FoundationExtensionsTests", dependencies: ["FoundationExtensions"])
]
)
1 change: 1 addition & 0 deletions Sources/FoundationExtensionsDynamic

0 comments on commit 79ebeb6

Please sign in to comment.