Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic filter parameter for the REST findAll interfaces #727

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Aug 29, 2023

Description

This suggests to introduce a generic filter parameter for the REST (GET /) interfaces based on the JSONPath specification.

TODOs

  • integration tests for all endpoints, actually for /applications only
  • check count queries, they need to include the permission check (I assume)
  • more detailed swagger description (if needed)

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 412 files.

Valid Invalid Ignored Fixed
294 1 117 0
Click to see the invalid file list
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/util/JsonPathFilterUtilTest.java

Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants