Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install components #364

Merged
merged 2 commits into from
Feb 14, 2024
Merged

update install components #364

merged 2 commits into from
Feb 14, 2024

Conversation

j042
Copy link
Member

@j042 j042 commented Feb 13, 2024

Overview

Installing all the targets makes a lot of things easy, but the size of wheel is getting out of hand due to explicit instantiation. So this PR removes all-inclusive target exports.

Addressed issues

  • huge wheels
  • pypi storage limit

@j042 j042 requested review from clemens-fricke and jzwar and removed request for clemens-fricke February 13, 2024 11:33
@jzwar
Copy link
Collaborator

jzwar commented Feb 13, 2024

Why did you remove the format runner?

@j042
Copy link
Member Author

j042 commented Feb 13, 2024

because we have pre-commit.ci and having one less job gets another build job to start earlier on busy days

@j042 j042 added the cibuildwheel-test Ask ci to test all wheel builds label Feb 14, 2024
@j042 j042 merged commit 63d3ce8 into main Feb 14, 2024
41 checks passed
@j042 j042 deleted the cu-smaller-bin branch February 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cibuildwheel-test Ask ci to test all wheel builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants