Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cibuildwheels #351

Merged
merged 1 commit into from
Feb 5, 2024
Merged

update cibuildwheels #351

merged 1 commit into from
Feb 5, 2024

Conversation

j042
Copy link
Member

@j042 j042 commented Feb 5, 2024 •
edited
Loading

Overview

fixes windows powershell issue

@j042 j042 added the cibuildwheel-windows-test Ask ci to test windows wheel builds label Feb 5, 2024
clemens-fricke
clemens-fricke approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@clemens-fricke clemens-fricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not check due to no access to windows. If the windows builds and tests run it should be fine. Especially since these changes are only in the workflow files and changes are only in version numbers of the used tools.

@j042
Copy link
Member Author

j042 commented Feb 5, 2024

yes - the label triggers window build test. see here

@j042 j042 merged commit ef25f27 into main Feb 5, 2024
13 of 29 checks passed
@j042 j042 deleted the fix-cibuildwheel branch February 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemens-fricke clemens-fricke clemens-fricke approved these changes

@jzwar jzwar Awaiting requested review from jzwar

Assignees
No one assigned
Labels
cibuildwheel-windows-test Ask ci to test windows wheel builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j042 @clemens-fricke