Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Buttons relays switches description #1215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ouinouin
Copy link

For the ESP_32 section, the relays switches buttons descritpion was incomplete, added descrption for _d (pulldown) _i (inverted active high) , _n (no pullup) taking reference the related esp8266 peripheral section when possible. did vertical bar separator cosmetic realignment on markdown source. (hence changed lines nr.)

For the ESP_32 section, the relays switches buttons descritpion was incomplete, 
added descrption for  _d (pulldown) _i (inverted active high) , _n (no pullup) taking reference the related esp8266 peripheral section when possible.
did vertical bar separator cosmetic realignment on markdown source. (hence changed lines nr.)
Copy link
Collaborator

@barbudor barbudor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution
Please review my comments

docs/Components.md Outdated Show resolved Hide resolved
docs/Components.md Outdated Show resolved Hide resolved
swapped the active high and active low according to @barbudor comments.
@DeflateAwning
Copy link
Contributor

@ouinouin, please look at the review suggestions and implement them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants