Fix ids for flexporter executeScript #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue with the flexporter where mappings that use
execute_scriptexport files without ids on the resources.New behavior
Resets ids by searching for and removing
urn:uuid:. Now flexporter run appropriately exports resources with ids when executing a script during mapping.Code changes
Copies code from line 151 of RunFlexporter.java which is used to fix an issue with HAPI ids. (Thanks for the fix @dehall!)
Testing guidance
Run the synthea flexporter with something like
./run_synthea -fm {mapping_file.yaml}where the mapping file contains someexecute_scriptmapping as described in the flexporter wiki. Look at the output patient file in output/fhir and confirm that the appropriate resources are exported with id fields.