-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shopware/app-bundle 4.0 variant #1673
feat: add shopware/app-bundle 4.0 variant #1673
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. shopware/app-bundle1.0 vs 4.0diff --git a/shopware/app-bundle/1.0/config/packages/shopware_app.yaml b/shopware/app-bundle/4.0/config/packages/shopware_app.yaml
index 645d80a3..7b722900 100644
--- a/shopware/app-bundle/1.0/config/packages/shopware_app.yaml
+++ b/shopware/app-bundle/4.0/config/packages/shopware_app.yaml
@@ -1,5 +1,7 @@
shopware_app:
- shop_class: App\Entity\Shop
name: '%env(SHOPWARE_APP_NAME)%'
secret: '%env(SHOPWARE_APP_SECRET)%'
-
+ # You should use doctrine or dynamodb as storage
+ storage: 'in-memory'
+ doctrine:
+ shop_class: App\Entity\Shop
diff --git a/shopware/app-bundle/4.0/post-install.txt b/shopware/app-bundle/4.0/post-install.txt
new file mode 100644
index 00000000..3c53f3e3
--- /dev/null
+++ b/shopware/app-bundle/4.0/post-install.txt
@@ -0,0 +1,6 @@
+ * Warning the shopware/app-bundle uses by default a in-memory database. You should use doctrine or dynamodb
+
+ For doctrine install the following packages: composer require doctrine/orm symfony/doctrine-bridge
+ For dynamodb install the following packages: composer require async-aws/async-aws-bundle async-aws/dynamo-db
+
+ Make sure to configure the correct storage after installing the packages in config/packages/shopware_app.yaml |
Head branch was pushed to by a user without write access
99ddfb0
to
8dbc5dc
Compare
Whats the best way here? I made doctrine optional as we support dynamodb in that bundle now too. So the new require flow is like: I make the default in-memory, so it does not require anything |
Head branch was pushed to by a user without write access
8dbc5dc
to
e496b92
Compare
Now it's fine, we don't support Symfony 5 |
We changed the schema of the yaml, therefore need a new recipe version