Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for --disable and --enable flags back #1977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Apr 8, 2024

Closes #1356
Closes #1622

In #1622 (comment) we read:

I consider adding it back at some point but it should be able to work with presets somehow. This is still need to be figured out.

I believe that by using globalOverrides, we can make it very easily, but I must admit, this was the first time I've worked with this code, so I might have missed something.

I did test the code though and it disabled the plugins I wanted when using CLI, so at the very least we're getting somewhere.

I've also increased JSDoc coverage here, mainly for my own sanity when working with these arrays of plugins. Hope you don't mind that scope creep :)

Closes svg#1356
Closes svg#1622

In svg#1622 (comment) we read:

> I consider adding it back at some point but it should be able to work with presets somehow. This is still need to be figured out.

I believe that adding it at the very last possible moment, AFTER initial list is resolved, will make it work with presets, and preserve the original behavior if the options aren't used at all.

I've also increased JSDoc coverage here, mainly for my own sanity when working with these arrays of plugins. Hope you don't mind that scope creep :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI option to disable plugins is no longer available CLI option to disable plugins is no longer available
1 participant