Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeHiddenElems is not idempotent #1955

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johnkenny54
Copy link
Contributor

removeHiddenElems was only removing the last of a chain of unreferenced elements - e.g., if a is referenced by b is referenced by c, and all are otherwise unreferenced, only c will be removed.

There is no change in regression mismatches or pixel mismatches. Total file compression in single-pass mode is increased by 19,540,048 bytes (2.5%). With the previous version, one link in the chain would be removed with each pass in multi-pass mode.

@johnkenny54 johnkenny54 marked this pull request as ready for review February 6, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant