Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mlh command #102

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

YashKandalkar
Copy link
Contributor

partially c/loses #75

What does this PR do?

Adds mlh command for showing upcoming hacks from https://mlh.io/seasons/2022/events
Also formatted a few files.

How can this be manually tested?

Run cyb!mlh command

What is the relevant issue link?

#75

Screenshots (if appropriate here)

Screenshot from 2021-07-10 21-04-53

Tell me if you want any changes :D

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 10, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.50%.

Quality metrics Before After Change
Complexity 10.15 🙂 9.93 🙂 -0.22 👍
Method Length 73.22 🙂 73.21 🙂 -0.01 👍
Working memory 9.59 🙂 9.49 🙂 -0.10 👍
Quality 61.46% 🙂 61.96% 🙂 0.50% 👍
Other metrics Before After Change
Lines 733 772 39
Changed files Quality Before Quality After Quality Change
bot.py 67.13% 🙂 66.99% 🙂 -0.14% 👎
scrapper.py 90.20% ⭐ 90.20% ⭐ 0.00%
cogs/Utils.py 56.41% 🙂 57.51% 🙂 1.10% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
cogs/Utils.py GeneralCog.avatar 37 ⛔ 304 ⛔ 15 😞 18.40% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
cogs/Utils.py GeneralCog.userinfo 33 ⛔ 373 ⛔ 14 😞 19.60% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
bot.py on_message_edit 10 🙂 108 🙂 24 ⛔ 44.05% 😞 Extract out complex expressions
bot.py on_member_remove 11 🙂 150 😞 11 😞 50.41% 🙂 Try splitting into smaller methods. Extract out complex expressions
bot.py on_member_join 9 🙂 141 😞 11 😞 53.21% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@starlightknown starlightknown merged commit df6e3eb into starlightknown:main Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants