Fix z-index additional bugs (#2651)

stanford-crfm · May 16, 2024 · 172cc26 · 172cc26
1 parent 3c37819
commit 172cc26
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/helm-frontend/src/components/LeaderboardTables.tsx b/helm-frontend/src/components/LeaderboardTables.tsx
@@ -185,7 +185,7 @@ export default function LeaderboardTables({
                     key={`${activeGroup}-${idx}`}
                     className={`${
                       idx === activeSortColumn ? "bg-gray-100" : "bg-white"
-                    } ${idx === 0 ? "left-0 z-10" : ""} ${
+                    } ${idx === 0 ? "left-0 z-40" : ""} ${
                       headerValue.description
                         ? "underline decoration-dashed decoration-gray-300	"
                         : ""
@@ -256,7 +256,7 @@ export default function LeaderboardTables({
                               : ""
                           } ${
                             cellIdx === 0
-                              ? "underline decoration-dashed decoration-gray-300 z-20"
+                              ? "underline decoration-dashed decoration-gray-300 z-10"
                               : "z-0"
                           }`}
                         >

diff --git a/helm-frontend/src/components/NavDropdown.tsx b/helm-frontend/src/components/NavDropdown.tsx
@@ -41,7 +41,7 @@ function NavDropdown() {
   }
 
   return (
-    <div className="dropdown z-40">
+    <div className="dropdown z-50">
       <div
         tabIndex={0}
         role="button"

diff --git a/helm-frontend/src/components/RowValue.tsx b/helm-frontend/src/components/RowValue.tsx
@@ -43,10 +43,14 @@ export default function RowValue({ value, title, hideIcon }: Props) {
     if (href) {
       return (
         <Link to={href} inTable title={title}>
-          <div className="flex items-center">
+          <div className="flex items-center ">
             {formatNumber(value.value)}
             {!hideIcon && (
-              <ArrowTopRightOnSquareIcon className="w-3 h-3 ml-1 opacity-30" />
+              <ArrowTopRightOnSquareIcon
+                className="w-3 h-3 ml-1"
+                stroke="#cbcbcb"
+                fill="#cbcbcb"
+              />
             )}
           </div>
         </Link>
@@ -66,7 +70,11 @@ export default function RowValue({ value, title, hideIcon }: Props) {
         <div className="flex items-center">
           {formatNumber(value.value)}
           {!hideIcon && (
-            <ArrowTopRightOnSquareIcon className="w-3 h-3 ml-1 opacity-30" />
+            <ArrowTopRightOnSquareIcon
+              className="w-3 h-3 ml-1"
+              stroke="#cbcbcb"
+              fill="#cbcbcb"
+            />
           )}
         </div>
       </Link>