Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

Seeded an off-by-one bug #1211

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Seeded an off-by-one bug #1211

merged 1 commit into from
Nov 4, 2020

Conversation

zvonimir
Copy link
Contributor

@zvonimir zvonimir commented Nov 4, 2020

Seeded what I think is a reasonable bug into this benchmark to create some benchmarks with bugs in this category.
It is a first step towards doing #1183.
If people are reasonably happy with this one, I'll do more.

@zvonimir
Copy link
Contributor Author

zvonimir commented Nov 4, 2020

This is the diff with the original file:

7894c7894
<     for (size_t i = 0; i < array_len; ++i) {
---
>     for (size_t i = 0; i < array_len - 1; ++i) {

@zvonimir zvonimir added C Task in language C new benchmarks labels Nov 4, 2020
Copy link
Member

@dbeyer dbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

@dbeyer
Copy link
Member

dbeyer commented Nov 4, 2020

I am merging, but I thought about the following:

  • Is there a way to document the bug in the code, that is, can you add a C comment above the line
    that states that this is the bug?
  • How to track the change in the .c file / original sources?

Could you please address this in a separete PR? (I do not want to hold it back because people obviously want to play around with it.)

@dbeyer dbeyer merged commit adc7616 into sosy-lab:master Nov 4, 2020
@zvonimir
Copy link
Contributor Author

zvonimir commented Nov 4, 2020

@dbeyer good suggestions! I'll add a comment with each bug I seed.
Btw, where are the original .c sources? I can't find them anywhere in the repo, but maybe I missed them.

@zvonimir zvonimir deleted the seed-bugs branch November 6, 2020 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C Task in language C new benchmarks
Development

Successfully merging this pull request may close these issues.

2 participants