chore: setup golangci-lint

.github/workflows/ci.yml

@@ -63,4 +63,32 @@ jobs:
           /tmp/cc-test-reporter after-build \
             --id ${{ secrets.CC_TEST_REPORTER_ID }} \
             --prefix "github.com/six78/2-story-points-cli" \
-            --exit-code $?
+            --exit-code $?
+
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.20'
+
+      - name: Install dependencies
+        run: |
+          go install go.uber.org/mock/mockgen@latest
+
+      - name: Generate
+        run: make generate
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: v1.56.2
+
+    permissions:
+      contents: read      # Required: allow read access to the content for analysis.
+      pull-requests: read # Optional: allow read access to pull request. Use with `only-new-issues` option.
+      checks: write

.golangci.yml

@@ -0,0 +1,10 @@
+linters:
+  disable-all: true
+  enable:
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+    - testifylint

Makefile

@@ -13,4 +13,7 @@ generate:
 	@go generate ./...
 
 test: generate
-	@gotestsum
+	@gotestsum
+
+lint:
+	golangci-lint run ./...

internal/testcommon/matchers/message_matcher.go

@@ -1,7 +1,6 @@
 package matchers
 
 import (
-	"fmt"
 	"github.com/six78/2-story-points-cli/pkg/protocol"
 	"testing"
 )
@@ -35,5 +34,5 @@ func (m *MessageMatcher) Matches(x interface{}) bool {
 }
 
 func (m *MessageMatcher) String() string {
-	return fmt.Sprintf("is protocol message")
+	return "is protocol message"
 }

internal/testcommon/matchers/online_matcher.go

@@ -2,7 +2,6 @@ package matchers
 
 import (
 	"encoding/json"
-	"fmt"
 	"github.com/six78/2-story-points-cli/internal/config"
 	"github.com/six78/2-story-points-cli/pkg/protocol"
 	"go.uber.org/zap"
@@ -48,7 +47,7 @@ func (m *OnlineMatcher) Matches(x interface{}) bool {
 }
 
 func (m *OnlineMatcher) String() string {
-	return fmt.Sprintf("is user online protocol message")
+	return "is user online protocol message"
 }
 
 func (m *OnlineMatcher) Wait() protocol.PlayerOnlineMessage {

internal/testcommon/matchers/state_matcher.go

@@ -2,7 +2,6 @@ package matchers
 
 import (
 	"encoding/json"
-	"fmt"
 	"github.com/six78/2-story-points-cli/pkg/protocol"
 	"testing"
 )
@@ -49,7 +48,7 @@ func (m *StateMatcher) Matches(x interface{}) bool {
 }
 
 func (m *StateMatcher) String() string {
-	return fmt.Sprintf("is state message matching custom condition")
+	return "is state message matching custom condition"
 }
 
 func (m *StateMatcher) State() protocol.State {

internal/testcommon/matchers/vote_matcher.go

@@ -1,7 +1,6 @@
 package matchers
 
 import (
-	"fmt"
 	"github.com/six78/2-story-points-cli/pkg/protocol"
 )
 
@@ -41,5 +40,5 @@ func (m *VoteMatcher) Matches(x interface{}) bool {
 }
 
 func (m *VoteMatcher) String() string {
-	return fmt.Sprintf("is any state message")
+	return "is any state message"
 }

pkg/game/game_test.go

@@ -135,7 +135,7 @@ func (s *Suite) TestStateSize() {
 	s.Require().NoError(err)
 
 	fmt.Println("state size", "bytes", len(stateMessage))
-	s.Require().True(len(stateMessage) < 100*1024, "state size should be less than 100 kilobytes")
+	s.Require().Less(len(stateMessage), 100*1024, "state size should be less than 100 kilobytes")
 }
 
 func (s *Suite) TestSimpleGame() {
@@ -194,7 +194,7 @@ func (s *Suite) TestSimpleGame() {
 		state = stateMatcher.Wait()
 		item := checkIssues(state.Issues)
 		s.Require().Nil(item.Result)
-		s.Require().Len(item.Votes, 0)
+		s.Require().Empty(item.Votes)
 		s.Logger.Info("match on deal first item")
 	}
 
@@ -263,7 +263,7 @@ func (s *Suite) TestSimpleGame() {
 		state = stateMatcher.Wait()
 		item := checkIssues(state.Issues)
 		s.Require().NotNil(item.Result)
-		s.Require().Equal(*item.Result, votingResult)
+		s.Require().Equal(votingResult, *item.Result)
 		s.Require().Len(item.Votes, 1)
 
 		vote, ok := item.Votes[s.dealer.Player().ID]
@@ -301,7 +301,7 @@ func (s *Suite) TestSimpleGame() {
 		state = stateMatcher.Wait()
 		item := checkIssues(state.Issues)
 		s.Require().Nil(item.Result)
-		s.Require().Len(item.Votes, 0)
+		s.Require().Empty(item.Votes)
 	}
 }
 

pkg/game/options_test.go

@@ -14,7 +14,8 @@ import (
 )
 
 func TestOptions(t *testing.T) {
-	ctx := context.WithValue(context.Background(), gofakeit.LetterN(3), gofakeit.LetterN(3))
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
 	transport := &mocktransport.MockService{}
 	storage := &mockstorage.MockService{}
 	logger := zap.NewNop()
@@ -72,7 +73,6 @@ func TestNoClock(t *testing.T) {
 
 func TestNoContext(t *testing.T) {
 	options := []Option{
-		WithContext(nil),
 		WithTransport(&mocktransport.MockService{}),
 		WithClock(clockwork.NewFakeClock()),
 	}