API Strong typing for the view layer #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
23 tasks
GuySartorelli
commented
Aug 22, 2024
Comment on lines
+66
to
+84
| private static array $composite_db = [ | ||
| "Hash" => "Varchar(255)", // SHA of the base content | ||
| "Filename" => "Varchar(255)", // Path identifier of the base content | ||
| "Variant" => "Varchar(255)", // Identifier of the variant to the base, if given | ||
| ]; | ||
|
|
||
| private static array $casting = [ | ||
| 'URL' => 'Varchar', | ||
| 'AbsoluteURL' => 'Varchar', | ||
| 'Basename' => 'Varchar', | ||
| 'Title' => 'Varchar', | ||
| 'MimeType' => 'Varchar', | ||
| 'String' => 'Text', | ||
| 'Tag' => 'HTMLFragment', | ||
| 'getTag' => 'HTMLFragment', | ||
| 'Size' => 'Varchar', | ||
| 'AttributesHTML' => 'HTMLFragment', | ||
| 'getAttributesHTML' => 'HTMLFragment', | ||
| ]; |
There was a problem hiding this comment.
These have just been moved from below, so they're not buried below methods.
GuySartorelli
commented
Aug 22, 2024
There was a problem hiding this comment.
There are methods in this class I have intentionally not added strict typing for, because they're defined in interfaces or are calling other code that isn't strongly typed, and I didn't want this PR to stretch tooo far beyond the goal of cleaning up the view layer.
GuySartorelli
force-pushed
the
pulls/3/strong-typing
branch
from
d39556f
to
fdb242d
Compare
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want a good base of known types for things that will be going into the template layer before I start abstracting it, and this gets me part of the way there.
Issue