Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #2226 #2582

Open
wants to merge 1 commit into
base: v1.10
Choose a base branch
from
Open

Fix bug #2226 #2582

wants to merge 1 commit into from

Conversation

magiclin99
Copy link

@magiclin99 magiclin99 commented Aug 26, 2024

Context:

Please refer to #2226

Root cause:

In vars.xml , when you use codec settings like this:
<X-PRE-PROCESS cmd="set" data="internal_codec_prefs=OPUS@16000h@1c,PCMU,PCMA,G729"/>

The switch_core_media.c line 5520 only takes the OPUS default rate (48k) instead of 16k in the config.

Because of this, FS won't be able to choose opus if your client asks for 16k opus. You will see same log symptom as #2226

Solution

uint32_t codec_rate = imp->actual_samples_per_second;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant