Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GH url for remote #138

Merged
merged 2 commits into from
Aug 23, 2024
Merged

use GH url for remote #138

merged 2 commits into from
Aug 23, 2024

Conversation

topepo
Copy link

@topepo topepo commented Aug 23, 2024

The remotes or pak packages can't install the GH version of mirai since the remote for doesn't include the repo name:

> pak::pak("shikokuchuo/mirai", ask = FALSE)
✔ Loading metadata database ... done                          
Error:                                                                     
! error in pak subprocess
Caused by error: 
! Could not solve package dependencies:
* shikokuchuo/mirai: Can't install dependency nanonext (>= 1.2.1.9002) 

This PR adds that to remotes:.

@shikokuchuo shikokuchuo self-requested a review August 23, 2024 12:58
Copy link
Owner

@shikokuchuo shikokuchuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ive added a remotes field instead otherwise it won't install locally. pak should then pick it up.

@shikokuchuo
Copy link
Owner

shikokuchuo commented Aug 23, 2024

Or else set repos to shikokuchuo.r-universe.dev. R-universe is really convenient in this respect.

FYI the intention has always been to stagger releases so dev mirai would only depend on release nanonext, but alas the development is so tightly integrated, this has rarely been possible!

@shikokuchuo shikokuchuo merged commit 7acaa3b into shikokuchuo:main Aug 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants