Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.4.1 to travis matrix #88

Closed
wants to merge 1 commit into from
Closed

Add Ruby 2.4.1 to travis matrix #88

wants to merge 1 commit into from

Conversation

timcraft
Copy link
Contributor

No description provided.

@sdsykes
Copy link
Owner

sdsykes commented Jun 17, 2017

Hmm, travis failed fetching external images during test. Not sure why that would be.

@timcraft
Copy link
Contributor Author

@sdsykes Looks like a fakeweb issue. This works:

$ irb -Ilib -r fastimage
irb(main):001:0> FastImage.size(HTTPSImage)
=> [9545, 6623]

Whereas this doesn't:

$ irb -Ilib -r fakeweb -r fastimage
irb(main):001:0> FastImage.size(HTTPSImage)
=> nil

@sdsykes
Copy link
Owner

sdsykes commented Jun 20, 2017

Yes, FakeWeb on 2.4.x is broken. But we are hoping for a new release very soon, see chrisk/fakeweb#57

In the mean time unless you want to propose using WebMock instead, I suggest we wait until FakeWeb is fixed before merging this change.

@timcraft
Copy link
Contributor Author

I've used WebMock a lot and can definitely recommend it, but I think makes sense to wait for a new FakeWeb release in this case given you're already using that.

@sdsykes
Copy link
Owner

sdsykes commented Sep 13, 2018

Eventually I made a release of a fork of FakeWeb chrisk/fakeweb#57 (comment) and added ruby 2.5 to the travis matrix.

@sdsykes sdsykes closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants