Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Health Endpoint #30

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Added Health Endpoint #30

merged 2 commits into from
Jun 20, 2024

Conversation

torbrenner
Copy link
Contributor

Currently only sends a default json and a 200 if spot is running. In future PR we could implement a check that beam is actually reachable.

@torbrenner torbrenner requested a review from Threated June 12, 2024 12:21
@torbrenner torbrenner self-assigned this Jun 12, 2024
@torbrenner torbrenner changed the base branch from main to develop June 12, 2024 12:21
Copy link
Member

@Threated Threated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving the HealthOutput struct to health.rs as well

@Threated
Copy link
Member

Lets merge this after #19 I think the merge conflicts here will be easier to resolve then the other way around

@Threated
Copy link
Member

We usually still merge into main and develop is really outdated can you rebase our changes to main and change the pr destination

@torbrenner torbrenner changed the base branch from develop to main June 20, 2024 08:04
@Threated Threated merged commit af7aba8 into main Jun 20, 2024
1 check passed
@Threated Threated deleted the feature/healthEndpoint branch June 20, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants