Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use CREATE instead of CREATE2 #339

Merged
merged 2 commits into from
May 3, 2024
Merged

refactor: use CREATE instead of CREATE2 #339

merged 2 commits into from
May 3, 2024

Conversation

smol-ninja
Copy link
Member

Fixes #337.

andreivladbrg
andreivladbrg approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

test/fork/merkle-lockup/MerkleLL.t.sol Outdated Show resolved Hide resolved
test/fork/merkle-lockup/MerkleLT.t.sol Outdated Show resolved Hide resolved
@andreivladbrg
Copy link
Member

i've tried to run the fork tests locally, it seems to not work for me, is it the same for you? @smol-ninja

@smol-ninja
Copy link
Member Author

i've tried to run the fork tests locally, it seems to not work for me

Yes its RPC endpoint issue. If you run them individually, it works.

@smol-ninja smol-ninja merged commit 1bf91e6 into staging May 3, 2024
7 checks passed
@smol-ninja smol-ninja deleted the feat/rusty-findings-1-4 branch May 3, 2024 11:36
@smol-ninja smol-ninja mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @andreivladbrg