Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #549 by integrating OpenZeppelin's
IERC4906
.cancel
MetadataUpdate
renounce
MetadataUpdate
setNFTDescriptor
BatchMetadataUpdate
withdraw
MetadataUpdate
Notes:
MetadataUpdate
event on everywithdraw
is thus: the state of the stream may change between withdrawals. We want to intercept every state-changing operation to make NFT marketplaces refresh our NFT SVGs.renounce
_toTokenId
passed toBatchMetadataUpdate
is 0 when_nextStreamId
is 1, but this should be a minor detail. I mean, one would hope that the_nextStreamId
will not retain the value of 1 for long. Even in the worst-case scenario when this is a problem for NFT marketplaces, we can create a stream ourselves before callingsetNFTDescriptor
.