-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "withdrawMaxAndTransfer" #561
Conversation
95b1ecc
to
5069eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to remove all internal return named args, shouldn't we also remove these?
v2-core/src/SablierV2LockupDynamic.sol
Line 313 in bc4b050
function _calculateStreamedAmount(uint256 streamId) internal view returns (uint128 streamedAmount) { |
v2-core/src/libraries/SVGElements.sol
Line 77 in bc4b050
returns (uint256 width, string memory card_) |
v2-core/src/libraries/SVGElements.sol
Line 237 in bc4b050
function calculatePixelWidth(string memory text, bool largeFont) internal pure returns (uint256 width) { |
|
dd345b1
to
80d7c1e
Compare
@andreivladbrg, waiting for your final confirmation before merging. |
chore: add "search.exclude" in VSCode settings refactor: unnamed return params in internal functions test: test "withdrawMaxAndTransfer"
80d7c1e
to
cd76539
Compare
Closes #559.
Full changelog: