Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "withdrawMaxAndTransfer" #561

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

PaulRBerg
Copy link
Member

Closes #559.

Full changelog:

  • feat: add "withdrawMaxAndTransfer"
  • chore: add "search.exclude" in VSCode settings
  • refactor: unnamed return params in internal functions
  • test: test "withdrawMaxAndTransfer"

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to remove all internal return named args, shouldn't we also remove these?

function _calculateStreamedAmount(uint256 streamId) internal view returns (uint128 streamedAmount) {

returns (uint256 width, string memory card_)

function calculatePixelWidth(string memory text, bool largeFont) internal pure returns (uint256 width) {

src/abstracts/SablierV2Lockup.sol Outdated Show resolved Hide resolved
@PaulRBerg
Copy link
Member Author

If we are going to remove all internal return named args, shouldn't we also remove these?

  • _calculateStreamedAmount: yes
  • card: yes
  • calculatePixelWidth: no, it's needed in the for loop

@PaulRBerg PaulRBerg force-pushed the feat/withdraw-max-and-transfer-from branch 2 times, most recently from dd345b1 to 80d7c1e Compare June 24, 2023 11:15
@PaulRBerg PaulRBerg mentioned this pull request Jun 26, 2023
2 tasks
@PaulRBerg
Copy link
Member Author

@andreivladbrg, waiting for your final confirmation before merging.

chore: add "search.exclude" in VSCode settings
refactor: unnamed return params in internal functions
test: test "withdrawMaxAndTransfer"
@PaulRBerg PaulRBerg force-pushed the feat/withdraw-max-and-transfer-from branch from 80d7c1e to cd76539 Compare June 27, 2023 09:16
@PaulRBerg PaulRBerg merged commit ecdbed5 into main Jun 27, 2023
2 checks passed
@PaulRBerg PaulRBerg deleted the feat/withdraw-max-and-transfer-from branch June 27, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide "withdrawMaxAndTransferFrom" functionality
3 participants