Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: slack notify integration #1042

Merged
merged 2 commits into from
Sep 16, 2024
Merged

ci: slack notify integration #1042

merged 2 commits into from
Sep 16, 2024

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg commented Sep 15, 2024

Closes this Notion task.

Using https://github.com/marketplace/actions/slack-notify to send a notification to the #ci-notifications channel on Slack whenever there's a failure in the scheduled workflow CI Deep.

@smol-ninja should this also be added to the fork tests workflow, as well as the staging branch?

@smol-ninja
Copy link
Member

smol-ninja commented Sep 15, 2024

Nice and thanks for doing this.

  • Yes, let's add it to the fork tests workflow so that we can track how many times they fail and if it's frequent, we can reduce runs or take some other action.

  • Not required for the staging branch. The runs on the staging branch are triggered by the new PRs for which the owners of the PR always receive emails. Secondly, this also means it will spam the Slack channel since the failed runs on staging PRs are quite frequent .

@PaulRBerg
Copy link
Member Author

Thanks. I will add it to the fork tests' workflow!

I now realize that we are no longer running CI Deep tests on the package-tethered version of the code base. Should we look into how to run the CI Deep workflow against staging instead of main?

@smol-ninja
Copy link
Member

IIRC we never used to run CI Deep tests on the staging branch. Thats why they are not running against the package tethering version. Are you proposing the following?

  • Run CI Fork tests only on main branch
  • Run CI Deep tests only on staging branch

If so, it makes sense to me.

@smol-ninja
Copy link
Member

I just realised CI Fork tests are not as deep as fork tests running in CI Deep. So we should keep running CI Deep against the main branch i.e.

  • Run CI Fork tests only on main branch
  • Run CI Deep tests on main and staging branch both

@PaulRBerg
Copy link
Member Author

Running CI Fork tests only on main and CI Deep only on main and staging makes sense.

But unfortunately, it is not possible to specify the branch when scheduling workflows. GitHub will default to the main branch (our default branch). To run the workflows against a different branch, we would need to pass a with: parameter to the checkout action. This, in turn, would require modifying all the reusable workflows to accept a with: parameter. And worse still, doing so would make it impossible to run the CI workflows manually from a different branch using the GitHub UI.

Let's stick with the defaults for now. We can manually run CI Deep against staging from time to time.

@PaulRBerg
Copy link
Member Author

So this should be good to merge now @smol-ninja.

@smol-ninja smol-ninja merged commit b55fca5 into main Sep 16, 2024
8 checks passed
@smol-ninja smol-ninja deleted the ci/slack-notify branch September 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants