chore: bump solhint, integrate Husky and lint-staged

[smol-ninja]

Changelog

• Closes Bump solhint and add the new rule to order imports #978
• Bump solhint to 5.0.3
  • Add a new rule to solhint: imports-order
  • Fix import order using solhint
  • Add new bun scripts: lint:sol:fix and lint:fix
• Install husky and lint-staged

Note

To bypass husky hook, just add -n to your commit (from git docs).

> git commit -S -n -m "your message"

[PaulRBerg]

very cool, thanks for this.

I wish this existed when we wrote the first lines of code in 2022!

[andreivladbrg]

Before giving a full review, I want to mention that we should rebase in staging from main as, for example, the formatting in precompiles was already addressed

I will rebase - hope not to cause conflicts in the PRs

[andreivladbrg]

Coming back re rebase, since there are conflicts between main and staging and many PRs open to staging, I will postpone until we merge all of them into staging (expect for this one) and then rebase from main.

[smol-ninja]

Even if formatting in precompiles was already addressed, why cant we merge it in staging and rebase later (in the end)? Resolving formatting conflicts isn't that hard.

[andreivladbrg]

why cant we merge it in staging and rebase later (in the end)?

we can, but the more commits there are in the staging branch, the more conflicts you’ll need to resolve.

Resolving formatting conflicts isn't that hard

well, it’s not difficult in terms of complexity, but the more conflicts you have to resolve, the more likely you are to miss something
for example, this issue: sablier-labs/v2-periphery#373 shouldn't have not existed, as the struct was added by mistake when rebased

[andreivladbrg]

The PR looks good, since foundry reverted the formatting style, let's merge this 👍

[smol-ninja]

Great. Merging now.