-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(refactor): periphery tests to use Bulloak #1025
Conversation
a3f8ee8
to
888d46e
Compare
test(tree): dont use is in tree
888d46e
to
0a5e62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, few comments bellow:
...periphery/integration/merkle-campaign/factory/create-merkle-instant/createMerkleInstant.tree
Outdated
Show resolved
Hide resolved
test/periphery/integration/merkle-campaign/factory/create-merkle-ll/createMerkleLL.tree
Outdated
Show resolved
Hide resolved
test/periphery/integration/merkle-campaign/factory/create-merkle-ll/createMerkleLL.tree
Outdated
Show resolved
Hide resolved
test/periphery/integration/merkle-campaign/factory/create-merkle-lt/createMerkleLT.tree
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed 2 commits.
Now it looks good on my end
Great. Thanks for making the changes. Looks good to me as well. |
* test(refactor): periphery tests to use Bulloak test(tree): dont use is in tree * test(tree): remove "does" word * test(tree): use shorter form in create factory --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
Closes #799
Tasks