Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(refactor): periphery tests to use Bulloak #1025

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

smol-ninja
Copy link
Member

Closes #799

Tasks

  • Refactor periphery tests to comply to bulloak check
  • Rewrite periphery tests to conform to BTT specs

test(tree): dont use is in tree
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, few comments bellow:

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed 2 commits.

Now it looks good on my end

@smol-ninja
Copy link
Member Author

Great. Thanks for making the changes. Looks good to me as well.

@smol-ninja smol-ninja merged commit 780f52e into staging Aug 28, 2024
9 checks passed
@smol-ninja smol-ninja deleted the test/periphery/bulloak branch August 28, 2024 16:28
andreivladbrg added a commit that referenced this pull request Sep 11, 2024
* test(refactor): periphery tests to use Bulloak

test(tree): dont use is in tree

* test(tree): remove "does" word

* test(tree): use shorter form in create factory

---------

Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants