Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for clippy #1364

Closed
wants to merge 4 commits into from
Closed

Add workflow for clippy #1364

wants to merge 4 commits into from

Conversation

vks
Copy link
Collaborator

@vks vks commented Dec 14, 2023

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy still only half convinces me of its utility, but since this project is relatively stable and this Action only uses the stable version, this addition seems reasonable.

Comment on lines 45 to 47
cargo clippy
--all-features
--message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this will check the rand and rand_core (a dependency), but not other crates.

Maybe use --all (but then --all-features does not apply correctly to other crates) or --no-deps and check each crate separately.

@vks
Copy link
Collaborator Author

vks commented Dec 14, 2023

It seems there are a bunch of deprecation warnings... ☹️

This is a bit frustrating, since this is the file that GitHub currently suggests... 😅

@newpavlov
Copy link
Member

In my experience it's better to use a fixed toolchain version for a Clippy job and bump it from time to time manually. Otherwise, on new stable release we may get unrelated CI failures in PRs.

@dhardy dhardy added the D-changes Do: changes requested label Apr 10, 2024
@newpavlov
Copy link
Member

#1448 has added a Clippy workflow, so I think we can close this PR?

@dhardy dhardy closed this May 12, 2024
@newpavlov newpavlov deleted the github-workflow-clippy branch May 22, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-changes Do: changes requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants