Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Change window tab icon, add check box to show password on create… #56

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

em2396
Copy link
Contributor

@em2396 em2396 commented Mar 15, 2024

What I did:

  • removed vite app from window tab, changed to runway reviews
  • removed vite icon and added runway reviews icon
  • added check box to create account for show password
  • small marginal changes to buttons

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Styling
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

✨ What's next?
Fix cypress tests, fix add review, delete test reviews

@em2396 em2396 requested a review from amysiu1028 March 15, 2024 03:44
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
runway-reviews-fe ✅ Ready (Inspect) Visit Preview Mar 15, 2024 3:44am
runway-reviews-fe-3ch7 ✅ Ready (Inspect) Visit Preview Mar 15, 2024 3:44am
runway-reviews-fe-evtz ❌ Failed (Inspect) Mar 15, 2024 3:44am

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for runwayreviews ready!

Name Link
🔨 Latest commit 78c13c6
🔍 Latest deploy log https://app.netlify.com/sites/runwayreviews/deploys/65f3c405da382100088beab1
😎 Deploy Preview https://deploy-preview-56--runwayreviews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amysiu1028 amysiu1028 merged commit f3646a3 into main Mar 19, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants