Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to AppWindow #65

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Fixes to AppWindow #65

wants to merge 19 commits into from

Conversation

A1Liu
Copy link
Collaborator

@A1Liu A1Liu commented Mar 6, 2023 •
edited
Loading

#29
#44

Note:

  • For now, not going to try to have the window history change. React doesn't pick up the changes if I mess with the raw window.history, and this is too complicated already. Route changes will have to just cause a full refresh.
  • When the iframe's src changes, the parent's history changes as well, because iframes are fun

@karimsa karimsa mentioned this pull request Mar 7, 2023
Merged
@A1Liu A1Liu marked this pull request as ready for review March 7, 2023 23:29
@karimsa karimsa marked this pull request as draft March 8, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A1Liu @karimsa