feat: Update non-olm-install script to setup conversion webhook #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/enhancement
|
Skipping CI for Draft Pull Request. |
svghadi
requested review from
anandf
and removed request for
reginapizza and
varshab1210
|
/retest |
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
svghadi
force-pushed
the
non-olm-webhook
branch
from
753ea9c
to
46b74e6
Compare
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
anandf
reviewed
Sep 25, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
anandf
approved these changes
Sep 25, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v4.13-kuttl-parallel |
openshift-merge-robot
merged commit b10480b
into
redhat-developer:master
18 checks passed
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
…at-developer#603) * Update non-olm-install script to setup conversion webhook Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * fix non-olm installation Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Move yq out of loop Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR updates non-olm operator install script to setup conversion webhook for automatic migration of ArgoCD v1alpha1 CRs to v1beta1. The webhook is enabled by default and is controlled by
ENABLE_CONVERSION_WEBHOOKenv var.For non-olm install, webhook cert management is off-loaded to Openshift Service CA operator. The required annotations for this are already added in configs so no special handling is required in the script.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Related GITOPS-3040
How to test changes / Special notes to the reviewer:
Same as feat: Add conversion webhook for ArgoCD v1alpha1 to v1beta1 migration argoproj-labs/argocd-operator#964.
kubectl kuttl test ./test/openshift/e2e/parallel/ --config ./test/openshift/e2e/parallel/kuttl-test.yaml --test 1-103_argocd_alpha_to_beta_conversion