Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit_db_cluster: Reset feature flags immediately after a failure to join #12163

Merged
merged 1 commit into from
Aug 31, 2024

Commits on Aug 30, 2024

  1. rabbit_db_cluster: Reset feature flags immediately after a failure to…

    … join
    
    [Why]
    If a node failed to join a cluster, `rabbit` was restarted then the
    feature flags were reset and the error returned. I.e., the error
    handling was in a single place at the end of the function.
    
    We need to reset feature flags after a failure because the feature flags
    states were copied from the remote node just before the join.
    
    However, resetting them after restarting `rabbit` was incorrect because
    feature flags were initialized in a way that didn't match the rest of
    the state. This led to crashes during the start of `rabbit`.
    
    [How]
    The feature flags are now reset after the failure to join but before
    starting `rabbit`.
    
    A new testcase was added to test this scenario.
    dumbbell committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    bfc6f83 View commit details
    Browse the repository at this point in the history