Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use member names when initializing #1867

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

DavisVaughan
Copy link
Member

Closes #1855

Copying r-lib/rlang@683214d

I'll also update the rlang library so we get the rlang change from ^ in vctrs too, and that will resolve all of the warnings.

Still not quite sure why that resolves it, but it does seem like the best solution since:

{{na, na}} // quiet on R 4.3, error on R 4.2
{na, na} // quiet on R 4.2, warn on R 4.3

We have determined this has something to do with R changing the internal definition of Rcomplex here:
wch/r-source@fb52ac1

@DavisVaughan DavisVaughan merged commit 94da308 into r-lib:main Aug 11, 2023
12 checks passed
@DavisVaughan DavisVaughan deleted the fix/r-complex-warnings branch August 11, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve warning about braces
1 participant