-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111513 #111613
gh-111513 #111613
Conversation
solved #111513 solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not quite what the original issue was getting at. The problem is got that these methods should accept strings, but that the error message you get when you pass the wrong type to their argument implies that they only accept integers.
The way to solve the original issue is to fix the error message.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
solved #111513
solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments