Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111513 #111613

Closed
wants to merge 3 commits into from
Closed

gh-111513 #111613

wants to merge 3 commits into from

Conversation

anuragdaksh7
Copy link

@anuragdaksh7 anuragdaksh7 commented Nov 1, 2023

solved #111513
solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments

solved #111513
solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments
Copy link

cpython-cla-bot bot commented Nov 1, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite what the original issue was getting at. The problem is got that these methods should accept strings, but that the error message you get when you pass the wrong type to their argument implies that they only accept integers.

The way to solve the original issue is to fix the error message.

@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@anuragdaksh7 anuragdaksh7 closed this by deleting the head repository Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants