Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change priors for TVPs #775

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Change priors for TVPs #775

wants to merge 47 commits into from

Commits on Apr 2, 2024

  1. MMM Lift test calibration (#590)

    * add scaling into lift test method
    
    * test scaling methods
    
    * test change of MMM likelihood
    
    * link up beta_channel parameters
    
    * change name to sigma
    
    * reorganize and edit
    
    * closes #406
    
    * address the feedback in docstrings
    
    * add more to docstring
    
    * format the docstring
    
    * be verbose for future devs
    
    * be explicit for the column max values
    
    * incorporate the feedback
    
    * hide cells and add to intro
    
    * add conclusion
    
    * switch to header 2
    
    * run notebook through
    
    * move the types together
    
    * separate model estimated from empirical
    
    * fix typos
    wd60622 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f055f98 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Drop python 3.9 support (#615)

    * drop python 3.9
    
    * try python 3.12
    
    * undo try python 3.12
    juanitorduz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8590b45 View commit details
    Browse the repository at this point in the history
  2. add lift tests check

    juanitorduz authored and twiecki committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    27a55d5 View commit details
    Browse the repository at this point in the history
  3. Add more content to the Gamma-Gamma Notebook (#573)

    * improve nb
    
    * rm warnings and add link to lifetimes quickstart
    
    * address comments
    
    * feedback part 3
    
    * remove warnings manually
    juanitorduz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f3ec2cf View commit details
    Browse the repository at this point in the history
  4. Add more content to the BG/NBD Notebook (#571)

    * add more info to the notebook
    
    * hide plots code
    
    * fix plot y labels
    
    * fix plot outputs and remove model build
    
    * improve final note probability plots
    
    * address comments
    
    * use quickstart dataset
    
    * feedback part 3
    
    * remowe warnings manually
    
    * feedback part 4
    juanitorduz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7b82cc3 View commit details
    Browse the repository at this point in the history
  5. Improve MMM Docs (#612)

    * improve mmm docs init
    
    * add more code examples to docstrings
    
    * minor improvemeents
    
    * typo
    
    * better phrasing
    
    * add thomas suggestion
    juanitorduz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    da9f025 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Fix clv plotting bugs and edits to Quickstart (#601)

    * move fixtures to conftest
    
    * docstrings and moved set_model_fit to conftest
    
    * fixed pandas quickstart warnings
    
    * revert to MockModel and add ParetoNBD support
    
    * quickstart edit for issue 609
    
    * notebook edit
    ColtAllen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    38b55a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffef5a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    a151330 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f33cef View commit details
    Browse the repository at this point in the history
  3. closes #520 (#621) dataset -> data

    wd60622 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c40c8b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    ff937f4 View commit details
    Browse the repository at this point in the history
  2. Remove ruff E501 ignore (#619)

    remove ruff E501 ignore
    juanitorduz committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e2dba27 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    b777eb5 View commit details
    Browse the repository at this point in the history
  2. [pre-commit.ci] pre-commit autoupdate (#629)

    updates:
    - [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7)
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
    pre-commit-ci[bot] and juanitorduz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4a737cf View commit details
    Browse the repository at this point in the history
  3. UP rule ruff (#635)

    juanitorduz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2be2f63 View commit details
    Browse the repository at this point in the history
  4. Add ruff RUF rules (#636)

    juanitorduz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    582d2ed View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Add Flake8-BugBear and Bandit (Security!) (#637)

    * fix potential bugs
    
    * minor improvements
    
    * remove rule for nb
    
    * fix test
    
    * improve tests syntax
    
    * use stacklevel 2 for warnings
    
    * use stacklevel 1 for warnings as they are used in public methods
    
    * ignore B904
    
    * undo change
    
    * ricardos feedback
    
    * use fit_posterior
    
    * Update pymc_marketing/clv/models/gamma_gamma.py
    
    Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
    
    * last fix XD
    
    ---------
    
    Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
    juanitorduz and ricardoV94 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c02d349 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Update version.txt (#640)

    juanitorduz committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    78964f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    18d926c View commit details
    Browse the repository at this point in the history
  2. Fix build badge (#645)

    juanitorduz committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ce41f5f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add downloads stats to README

    juanitorduz authored and twiecki committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    818781a View commit details
    Browse the repository at this point in the history
  2. Pareto/NBD Example Notebook (#646)

    * notebook opening and imports
    
    * model definition markdown
    
    * Data Load Notebook section
    
    * WIP model fitting section
    
    * added notebook to docs directory
    
    * notebook edits and graph code
    
    * ppc section and nb cleanup
    
    * demz sampling and WIP plotting
    
    * WIP predictive plots
    
    * WIP heatmap plots
    
    * predictive plots
    
    * WIP covariates and nbqa-ruff edits
    
    * covariate section
    
    * plot additions
    
    * fig sizes
    
    * remove model file
    ColtAllen committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    91564cf View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. add spaces, increase indentation, and fix number order to Pareto note…

    …book (#651)
    
    * add spaces, increase indentation, and fix number order
    
    * explicit with 6
    wd60622 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7034e28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d531d0c View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Plot Waterfall Components Decomposition (#631)

    * Creating plot waterfall
    
    Co-Authored-By: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com>
    
    * requested changes
    
    * pre-commit
    
    ---------
    
    Co-authored-by: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com>
    cetagostini-wise and cetagostini committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    1c186f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Update resources.md (#652)

    Databricks should have a lower-case b.
    coreyabs-db committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b36b0ac View commit details
    Browse the repository at this point in the history
  2. fix ylabel (#654)

    juanitorduz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ae6ae1d View commit details
    Browse the repository at this point in the history
  3. [pre-commit.ci] pre-commit autoupdate (#655)

    updates:
    - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2)
    - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0)
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    pre-commit-ci[bot] committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    41dda4f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Lift test fixes (#656)

    * support for negative values and dates (if used)
    
    * fix terrible spelling
    
    * test dates in coords
    
    * cover numpy objects
    
    * consolidate the tests
    wd60622 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a89bd93 View commit details
    Browse the repository at this point in the history
  2. add to docstrings tanh saturation (#657)

    Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
    wd60622 and juanitorduz committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5a93ef2 View commit details
    Browse the repository at this point in the history
  3. Add quickstart to readme (#653)

    * add quickstartt to readme
    
    * add pymc labs logo
    
    * typos
    
    * add community links
    
    * fixes
    juanitorduz committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b58f9b6 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Add contributors to README (#659)

    * Add contributors to README
    
    * small code style improvements
    juanitorduz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e63929a View commit details
    Browse the repository at this point in the history
  2. Time varying intercept (#628)

    * Add time-varying prior functionality to DelayedSaturatedMMM
    
    * resolve wd's comments
    
    * resolve failing pre-commits
    
    * add tvp_kwargs to model_config
    
    * fix typo
    
    * replace softplus
    
    * resolve minor review comments
    
    * Add option to supply `ax` to `plot_posterior_predictive`
    
    * bugfix: time_index was not set correctly for OOS
    
    If provided `X` to `_data_setter` was *not* the immediate sequence following the training set, the time_index would we wrong. With this fix, the `date["time_index"]` which gets set upon providing a new `X`, is inferred from the `self.date_column` column of provided `X` (by comparing it to same date column in the training data `self.X`).
    
    * Clean up example notebook
    
    * Make utility function `transform_1d_array`
    
    * 'tvp_kwargs' -> 'intercept_tvp_kwargs'
    
    * move `infer_time_index` into utils
    
    * add tests for new utils
    
    * small fixes (found in tests)
    
    * add tests to cover all added cases
    
    * fix ruff check
    
    * update typehints
    
    * resolve review comments
    
    * refactor model logic for tv intercept
    
    * address review comment for util test
    
    * .
    
    * fix documentation link
    
    * change variable name
    
    * fix hsgp_dims
    
    * update time_varying_prior to be centered on 1
    
    * review fixes
    
    * fix broken test
    
    * add final tests
    
    * fix coverage issues
    
    * Update tests/mmm/test_tvp.py
    
    Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
    
    * Update pymc_marketing/mmm/tvp.py
    
    Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
    
    * Update tests/mmm/test_tvp.py
    
    Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
    
    * Update tests/mmm/test_tvp.py
    
    Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
    
    * significant improvements to notebook
    
    * fix heading
    
    * update notebook to make it EVEN better
    
    * update legend, add watermark
    
    * fix intro
    
    * fix broken test
    
    * copy sweep with grammarly
    
    ---------
    
    Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
    ulfaslak and wd60622 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f0097e2 View commit details
    Browse the repository at this point in the history
  3. Update README.md (#660)

    nialloulton committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8e67803 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Add tv intrecept to readme (#661)

    * add tv intrecept to readme
    
    * add to comparison table
    juanitorduz committed May 2, 2024
    Configuration menu
    Copy the full SHA
    fd6b331 View commit details
    Browse the repository at this point in the history
  2. fix title level (#663)

    juanitorduz committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b27da9e View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary NonImplemented errors from abstract methods (#662)

    * ignore non-implemented
    
    * remove not implemented error from abstract classes
    
    * simplify docstrings
    juanitorduz committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b785baa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    19bbf6d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    fc37560 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Configuration menu
    Copy the full SHA
    5f54d8e View commit details
    Browse the repository at this point in the history
  2. add license (#673)

    juanitorduz committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0e8ac45 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    48c88b2 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. add sample_kwargs (#676)

    juanitorduz committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2374a0c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4dbf943 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    61da9c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. first commit

    bwengals committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bc15109 View commit details
    Browse the repository at this point in the history