Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supported for CLI margins option. #111

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Niremizov
Copy link

@Niremizov Niremizov commented Sep 4, 2024

Bug reported here camelot-dev#499
Pull to original repository camelot-dev#500 (commits differs, cause to rebase issues)

@Niremizov
Copy link
Author

Hope that now finally fixed tests.

@bosd
Copy link
Collaborator

bosd commented Sep 14, 2024

Let's see the results 😉
Again thanks for your work on this!

@bosd
Copy link
Collaborator

bosd commented Sep 16, 2024

Tests are good now, can you please squash your lats 2 commits?
(so the fixes are included in the add tests commit)

@Niremizov Niremizov force-pushed the bugfix/499/nr/ProccesMarginsCLIOption04092024 branch from c346bac to c52762e Compare September 16, 2024 09:22
@Niremizov
Copy link
Author

Done

Copy link
Collaborator

@foarsitter foarsitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosd bosd merged commit 6a92acb into py-pdf:main Sep 17, 2024
12 checks passed
@bosd bosd mentioned this pull request Sep 19, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants