Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty package sets in package set update payload #611

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Allow empty package sets in package set update payload #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions app/src/App/API.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,20 +214,23 @@ packageSetUpdate payload = do
, PackageSets.printRejections candidates.rejected
]

if Map.isEmpty candidates.accepted then do
Except.throw "No packages in the suggested batch can be processed; all failed validation checks."
else do
let changeSet = candidates.accepted <#> maybe Remove Update
Notify.notify "Attempting to build package set update."
PackageSets.upgradeAtomic latestPackageSet (fromMaybe prevCompiler payload.compiler) changeSet >>= case _ of
Nothing ->
Except.throw "The package set produced from this suggested update does not compile."
Just packageSet -> do
let commitMessage = PackageSets.commitMessage latestPackageSet changeSet (un PackageSet packageSet).version
Registry.writePackageSet packageSet commitMessage
Notify.notify "Built and released a new package set! Now mirroring to the package-sets repo..."
Registry.mirrorPackageSet packageSet
Notify.notify "Mirrored a new legacy package set."
when (Map.isEmpty candidates.accepted) $ case payload.compiler of
Just compiler | compiler > prevCompiler ->
Log.debug $ "No packages in the suggested batch can be processed, but the compiler version " <> Version.print compiler <> " was upgraded."
_ ->
Except.throw "No packages in the suggested batch can be processed (all failed validation checks) and the compiler version was not upgraded, so there is no upgrade to perform."

let changeSet = candidates.accepted <#> maybe Remove Update
Notify.notify "Attempting to build package set update."
PackageSets.upgradeAtomic latestPackageSet (fromMaybe prevCompiler payload.compiler) changeSet >>= case _ of
Nothing ->
Except.throw "The package set produced from this suggested update does not compile."
Just packageSet -> do
let commitMessage = PackageSets.commitMessage latestPackageSet changeSet (un PackageSet packageSet).version
Registry.writePackageSet packageSet commitMessage
Notify.notify "Built and released a new package set! Now mirroring to the package-sets repo..."
Registry.mirrorPackageSet packageSet
Notify.notify "Mirrored a new legacy package set."

type AuthenticatedEffects r = (REGISTRY + STORAGE + GITHUB + PACCHETTIBOTTI_ENV + NOTIFY + LOG + EXCEPT String + AFF + EFFECT + r)

Expand Down
Loading