Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/web 943 playspeed design #1074

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

1t1e1
Copy link
Contributor

@1t1e1 1t1e1 commented Jan 22, 2023

I didn't complete #943, so I think it would be beneficial to make my progress, notes, etc. public here.

@1t1e1
Copy link
Contributor Author

1t1e1 commented Jan 22, 2023

Remain Todos for window.prompt version

  • style fixes
  • validation for input from window.prompt, check error message.
  • check all TODO:SS before merge

Todos for Slider component with modal

  • Design Slider Component
  • Look at how Login modal works
  • etc.

@1t1e1 1t1e1 force-pushed the feat/web_943_playspeed_design branch from 6c460b8 to 104fa55 Compare January 22, 2023 22:20
@mitchdowney
Copy link
Member

@1t1e1 awesome, thanks for sharing your progress!

I will be mostly away from a computer this week, so I apologize in advance if I don't get to this as soon as I'd like. It might not be until next week when I could review and merge (or finish it and merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants